search

conda-forge / imagecodecs-feedstock

A conda-smithy repository for imagecodecs.
BSD 3-Clause "New" or "Revised" License
3 stars 9 forks source link

Please include `libjxl` so that imagecodec's JPEG-XL extension can be enabled #48

Open JackKelly opened 2 years ago

JackKelly commented 2 years ago

Issue:

I'd love to be able to use imagecodecs.jpegxl_encode(). (JPEG-XL is the "new kid on the block" of image compression, and looks like it could provide state-of-the-art compression for a range of use-cases). Unfortunately, imagecodecs's JPEG-XL extension is not currently enabled in the conda-forge build because conda-forge does not include libjxl. (Although imagecodecs's JPEG-XL extension is functional in the Windows and 64-bit wheels)

(I wrote this issue on the advice of imagecodec's author in this comment: https://github.com/cgohlke/imagecodecs/issues/29#issuecomment-1024316719)

hmaarrfk commented 2 years ago

is the conda package available? I tried to build a few of them I the past. help is appreciated here!

hmaarrfk commented 2 years ago

I tried to look into this a little bit, and this is what i learned:

  1. jpegxl requires highway, even though they don't seem to list it as a hard dependecy on their README.
  2. Unfortunately, highway isn't really built with shared libraries, and enough modularity in CMake. In google fashion, it is built to be included as a submodule in other C++ Projects which is rather annoying when building it in a shared library environment.
  3. I suggest we wait until version 0.15.1 or 0.16.0, it will have enough fixes to the build system so that it should be installable. At least this is my thinking.
hmaarrfk commented 2 years ago

If you want to help, you can likely build off: https://github.com/conda-forge/staged-recipes/pull/17797 or just start fresh to bulid highway.

JackKelly commented 2 years ago

Very cool, thank you so much for doing all this research!

I'm really sorry but I'm afraid I'm unlikely to be able to make time to work on this any time soon, I'm sorry, I would've loved to help.

hmaarrfk commented 1 year ago

I think I built highway a while back. Remains actually building jpegxl

https://github.com/conda-forge/staged-recipes/pull/17812