conda-forge / intel-compiler-repack-feedstock

A conda-smithy repository for intel-compiler-repack.
BSD 3-Clause "New" or "Revised" License
3 stars 7 forks source link

Fix activate scripts for dpcpp compiler #17

Closed isuruf closed 10 months ago

isuruf commented 10 months ago

Checklist

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

napetrov commented 10 months ago

Hi @isuruf - is there content for this PR? Not sure I understand everything here

oleksandr-pavlyk commented 10 months ago

Yes, a context would be nice.

Instead of specifying --gcc-toolchain, --sysroot, and --target in $CFLAGS, we leverage support for compiler configuration files:

# Intel LLVM must cooperate with compiler and sysroot from conda
echo "--gcc-toolchain=${BUILD_PREFIX} --sysroot=${BUILD_PREFIX}/${HOST}/sysroot -target ${HOST}" > icpx_for_conda.cfg
export ICPXCFG="$(pwd)/icpx_for_conda.cfg"
export ICXCFG="$(pwd)/icpx_for_conda.cfg"

Perhaps this could be used in the compiler activation script.

isuruf commented 10 months ago

This is for https://github.com/conda-forge/onednn-feedstock/pull/53. Yeah we can use that script.

isuruf commented 10 months ago

@napetrov can you review and merge?