Closed igorsafo closed 2 months ago
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
dpcpp_impl_win-64
because it is not a known output of this recipe: ['intel-cmplr-lic-rt', 'intel-cmplr-lib-rt', 'intel-fortran-rt', 'intel-opencl-rt', 'dpcpp-cpp-rt', 'dpcpp_impl_linux-64', 'dpcpp_linux-64', 'oneccl-devel', 'intel-compiler-repack'].@conda-forge-admin, please rerender
@igorsafo These changes in activation script just work around a problem that should really be fixed in intel::dpcpp_win-64
.
We have to do this in dpctl
's build script: https://github.com/IntelPython/dpctl/blob/master/conda-recipe/bld.bat#L3-L4
The fix for this is that %PREFIX%\include%
folder in intel::dpcpp_impl_win-64
should really have been placed in %PREFIX%\Library\include
, ref: https://github.com/conda-forge/intel-compiler-repack-feedstock/pull/4#discussion_r960084632
Something along this lines would resolve the need to set LIB
variable, e.g. %PREFIX%\compiler\lib
be installed into %PREFIX%\Library\lib
, but I am less sure about this.
Such layout reshuffling could be done during repackaging by conda-forge, for example.
@igorsafo These changes in activation script just work around a problem that should really be fixed in
intel::dpcpp_win-64
.We have to do this in
dpctl
's build script: https://github.com/IntelPython/dpctl/blob/master/conda-recipe/bld.bat#L3-L4The fix for this is that
%PREFIX%\include%
folder inintel::dpcpp_impl_win-64
should really have been placed in%PREFIX%\Library\include
, ref: #4 (comment)Something along this lines would resolve the need to set
LIB
variable, e.g.%PREFIX%\compiler\lib
be installed into%PREFIX%\Library\lib
, but I am less sure about this.Such layout reshuffling could be done during repackaging by conda-forge, for example.
Thanks for the explanation. Will you be able to fix the issue on intel::dpcpp_win-64
side?
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)In the current version of the compiler package on Windows when user activates an environment with dpcpp compiler and tries to build an application or a library the following issues happen:
LIB
is extended with%CONDA_PREFIX%\Library\lib
the compiler detection passes but the building process fails due to missing headers:The same issue happens if user tries to build a simple application:
In file included from simple.cpp:1: C:\Users\igorsafo\AppData\Local\miniconda3\envs\dpcpp\Library\lib\clang\17\include\CL/sycl.hpp(11,10): fatal error: 'sycl/sycl.hpp' file not found
include <sycl/sycl.hpp>
1 error generated.