conda-forge / intel-compiler-repack-feedstock

A conda-smithy repository for intel-compiler-repack.
BSD 3-Clause "New" or "Revised" License
3 stars 7 forks source link

2022.1.0 release #4

Closed oleksandr-pavlyk closed 1 year ago

oleksandr-pavlyk commented 1 year ago

Checklist

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

oleksandr-pavlyk commented 1 year ago

I have verified locally that conda build recipe -c conda-forge works fine and the added test step of dpcpp simple.cpp -o simple.exe worked on Ubuntu.

Any insight into why it may be failing in the CI?

napetrov commented 1 year ago

dpcpp: error: linker command failed with exit code 1 (use -v to see invocation)

Something to do with toolchain on system. Might be it's due to OS/glibc/gcc versions in image in conda-forge CI.

beckermr commented 1 year ago

Oh my bad. You need the cos7 sysroot. Sit tight.

beckermr commented 1 year ago

@isuruf @oleksandr-pavlyk I think we need to properly pin this compiler to require the cos7 sysroot. I don't know where precisely the best place is to do this.

beckermr commented 1 year ago

@conda-forge-admin rerender

oleksandr-pavlyk commented 1 year ago

Thank you for your help, @beckermr !

beckermr commented 1 year ago

Happy to help! We still need to change the recipe to pin cos7 properly. Let's wait to merge until we work that out.

beckermr commented 1 year ago

OK @isuruf @oleksandr-pavlyk commit https://github.com/conda-forge/intel-compiler-repack-feedstock/pull/4/commits/2a28956d9867f80729b11495424087d0509c5a3b does the following:

  1. I added an __glibc >=2.7<3.0.a0 strong run export to the dpcpp compiler impl and wrapper package.
  2. I added a run-time constraint on the appropriate linux sysroot for the dpcpp compiler impl package.

This will ensure that the compiler is running with the cos7 sysroot always and that anything built with it gets the proper runtime virtual package constraint that will force the users of builds to have a cos7 or later system.

cc @conda-forge/core for viz and advice

beckermr commented 1 year ago

@oleksandr-pavlyk Is there documentation somewhere on what OS versions the dpcpp compiler supports for both itself and the executables it makes?

oleksandr-pavlyk commented 1 year ago

I suppose it is here: https://www.intel.com/content/www/us/en/developer/articles/system-requirements/intel-oneapi-dpcpp-system-requirements.html

Supported minimum versions of distributed libraries that the compilers are built on: GCC - 7.3.0, BINUTILS- 2.30, GLIBC-2.27

beckermr commented 1 year ago

Awesome. Then the pinnings here make sense (and are probably too liberal).

Let's wait a week or so and if nobody objects we will merge.

oleksandr-pavlyk commented 1 year ago

@napetrov I think this can be merged now. Thank you everyone for reviewing and helping get this into proper shape. It took a village.