Closed oleksandr-pavlyk closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
dpcpp_impl_win-64
because it is not a known output of this recipe: ['intel-cmplr-lic-rt', 'intel-cmplr-lib-rt', 'intel-fortran-rt', 'intel-opencl-rt', 'dpcpp-cpp-rt', 'dpcpp_impl_linux-64', 'dpcpp_linux-64', 'oneccl-devel', 'intel-compiler-repack'].Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
dpcpp_impl_win-64
because it is not a known output of this recipe: ['intel-cmplr-lic-rt', 'intel-cmplr-lib-rt', 'intel-fortran-rt', 'intel-opencl-rt', 'dpcpp-cpp-rt', 'dpcpp_impl_linux-64', 'dpcpp_linux-64', 'oneccl-devel', 'intel-compiler-repack'].I have verified locally that conda build recipe -c conda-forge
works fine and the added test step of dpcpp simple.cpp -o simple.exe
worked on Ubuntu.
Any insight into why it may be failing in the CI?
dpcpp: error: linker command failed with exit code 1 (use -v to see invocation)
Something to do with toolchain on system. Might be it's due to OS/glibc/gcc versions in image in conda-forge CI.
Oh my bad. You need the cos7 sysroot. Sit tight.
@isuruf @oleksandr-pavlyk I think we need to properly pin this compiler to require the cos7 sysroot. I don't know where precisely the best place is to do this.
@conda-forge-admin rerender
Thank you for your help, @beckermr !
Happy to help! We still need to change the recipe to pin cos7 properly. Let's wait to merge until we work that out.
OK @isuruf @oleksandr-pavlyk commit https://github.com/conda-forge/intel-compiler-repack-feedstock/pull/4/commits/2a28956d9867f80729b11495424087d0509c5a3b does the following:
__glibc >=2.7<3.0.a0
strong run export to the dpcpp compiler impl
and wrapper package. impl
package.This will ensure that the compiler is running with the cos7 sysroot always and that anything built with it gets the proper runtime virtual package constraint that will force the users of builds to have a cos7 or later system.
cc @conda-forge/core for viz and advice
@oleksandr-pavlyk Is there documentation somewhere on what OS versions the dpcpp compiler supports for both itself and the executables it makes?
I suppose it is here: https://www.intel.com/content/www/us/en/developer/articles/system-requirements/intel-oneapi-dpcpp-system-requirements.html
Supported minimum versions of distributed libraries that the compilers are built on: GCC - 7.3.0, BINUTILS- 2.30, GLIBC-2.27
Awesome. Then the pinnings here make sense (and are probably too liberal).
Let's wait a week or so and if nobody objects we will merge.
@napetrov I think this can be merged now. Thank you everyone for reviewing and helping get this into proper shape. It took a village.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)