Closed rgommers closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
@rgommers thanks a lot for PR. Looks good overall.
In terms of versions/comments - one of ideas was to have conda-forge and anaconda recipes aligned - https://github.com/AnacondaRecipes/intel_repack-feedstock/blob/master/recipe/meta.yaml
But they are diverged now....
So probably the simple fix for now would be to have comment added, and as next step better combined version can be created (anaconda recipe would require some cleanup daal -> dal )
In addition to these changes I was tempted to rename
buildnum
andversion
, because it took me a while to realize that those are specific to DAL, and the build numbers for it need to come from https://anaconda.org/intel/dal/files. Alternatively, adding a comment would be useful. Any preference?