conda-forge / ipython-feedstock

A conda-smithy repository for ipython.
BSD 3-Clause "New" or "Revised" License
2 stars 34 forks source link

Rebuild python39, skipping some optional test dependencies #114

Closed bollwyvl closed 4 years ago

bollwyvl commented 4 years ago

Checklist

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 4 years ago

Gah, messed up my selector... trying again locally...

bollwyvl commented 4 years ago

Lots of :green_circle:, but there is no victory until windows works...

jakirkham commented 4 years ago

Looks like everything passed! 🎉 🟢

Not sure why Travis CI shows up twice (once as passing and once as pending). Saw the same thing on another build earlier. Maybe some hiccup between Travis CI and GitHub's API. Anyways I think we can safely ignore it 😉

bollwyvl commented 4 years ago

Sure, would be appropriate for ipykernel, but probably not for mpl/ioloopy things...

On Tue, Oct 13, 2020, 18:12 Filipe notifications@github.com wrote:

@ocefpaf commented on this pull request.

In recipe/meta.yaml https://github.com/conda-forge/ipython-feedstock/pull/114#discussion_r504288192 :

 - requests
  • testpath
  • would ideally be in the block below, but messes with re-rendering

    • numpy
  • {% if not building_on_new_platform %}

We need to check if we can do test downstreams instead: https://docs.conda.io/projects/conda-build/en/latest/resources/define-metadata.html#downstream-tests

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/conda-forge/ipython-feedstock/pull/114#pullrequestreview-507864919, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCRECA5LUUGFA4ZNY2LDSKTGDTANCNFSM4SPSZ2YA .