[wip] restore tests commented out for pypy37 migration

conda-forge / ipython-feedstock

A conda-smithy repository for ipython.

BSD 3-Clause "New" or "Revised" License

2 stars 34 forks source link

[wip] restore tests commented out for pypy37 migration #126

Closed bollwyvl closed 3 years ago

bollwyvl commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.
doesn't need to be merged/shipped (just restores tests)
can help verify https://github.com/conda-forge/ipykernel-feedstock/pull/73 (etc)

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 3 years ago

doesn't need to be merged/shipped (just restores tests)

Should IMO definitely be merged, because the recipe at the moment should not be considered functional for pypy. If you don't increase the build number (and there are no major changes in the pinning causing the build hashes to change), no new packages will be uploaded.

h-vetinari commented 3 years ago

@conda-forge-admin, please restart ci

h-vetinari commented 3 years ago

Ping @bollwyvl, this should still be merged at some point. :)

bollwyvl commented 3 years ago

tuns out this didn't actually restore the tests, due to a selector... currently working this over on #128