conda-forge / ipython-feedstock

A conda-smithy repository for ipython.
BSD 3-Clause "New" or "Revised" License
2 stars 34 forks source link

IPython 8.0.0b1 #153

Closed bollwyvl closed 2 years ago

bollwyvl commented 2 years ago

Checklist

Notes:

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/ipython-feedstock/actions/runs/1625041939.

bollwyvl commented 2 years ago

ick:

Building wheels for collected packages: ipython
  Created temporary directory: /tmp/pip-wheel-97fgj5oh
  Running command /home/conda/feedstock_root/build_artifacts/ipython_1640560025638/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/bin/python /home/conda/feedstock_root/build_artifacts/ipython_1640560025638/_build_env/venv/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py build_wheel /tmp/tmpme2e3c2o
  Destination directory: /tmp/pip-wheel-97fgj5oh
  Building wheel for ipython (pyproject.toml): started
  /home/conda/feedstock_root/build_artifacts/ipython_1640560025638/_build_env/venv/lib/python3.10/site-packages/_distutils_hack/__init__.py:24: UserWarning: Distutils was imported before Setuptools, but importing Setuptools also replaces the `distutils` module in `sys.modules`. This may lead to undesirable behaviors or errors. To avoid these issues, avoid using distutils directly, ensure that setuptools is installed in the traditional way (e.g. not an editable install), and/or make sure that setuptools is always imported before distutils.
    warnings.warn(
  /home/conda/feedstock_root/build_artifacts/ipython_1640560025638/_build_env/venv/lib/python3.10/site-packages/_distutils_hack/__init__.py:36: UserWarning: Setuptools is replacing distutils.
    warnings.warn("Setuptools is replacing distutils.")
  running bdist_wheel
  Traceback (most recent call last):
    File "/home/conda/feedstock_root/build_artifacts/ipython_1640560025638/_build_env/venv/lib/python3.10/site-packages/setuptools/_distutils/sysconfig.py", line 488, in _init_posix
      _temp = __import__(name, globals(), locals(), ['build_time_vars'], 0)
  ModuleNotFoundError: No module named '_sysconfigdata__linux_aarch64-linux-gnu'

@conda-forge/help-python @conda-forge/help-python-c any thoughts?

Carreau commented 2 years ago

Thanks for doing all of that,

I think the last few imports of distutils can be removed, I have no clue what they are doing but the final tgz/wheel are quasi identical, so maybe worth trying ?

bollwyvl commented 2 years ago

I meant to dig into this up some more, but see that https://github.com/ipython/ipython/pull/13423 has already gone through. I can wait to test a future beta, if we think that's forthcoming, or i can keep poking at it (don't have a ppc machine/docker/vm approach around :blush: ).

bollwyvl commented 2 years ago

@conda-forge/ipython any regrets about merging this? it seems like we actually shed a lot of test skips, so i feel pretty good about it, overall.

bollwyvl commented 2 years ago

With no thundering dissent, i'll go ahead and merge this.