search

conda-forge / ipython-feedstock

A conda-smithy repository for ipython.
BSD 3-Clause "New" or "Revised" License
2 stars 34 forks source link

Install with pip #2

Closed minrk closed 8 years ago

minrk commented 8 years ago

ensures setuptools metadata is defined, so downstream packages installed by pip can depend on ipython[notebook], for instance.

decorator dependency is declared, as it really is needed. python -c 'import IPython' fails if decorator is missing.

conda-forge-admin commented 8 years ago

Hi! This is the friendly conda-forge-admin automated user.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

minrk commented 8 years ago

My first conda-forge PR, let's see how it goes.

pelson commented 8 years ago

My first conda-forge PR, let's see how it goes.

It's all green - that is a good start! 😄

I've asked a question about pip as a dependency, which I think we can address in another PR if it turns out to be an issue.

minrk commented 8 years ago

pip is not part of the stdlib, but it is a third-party package that is part of default installations. ensurepip, which installs the third-party pip package, is part of the stdlib.

The pip dependency is typically redundant, because Continuum added pip to the Python package. This wasn't always the case (I bugged them to add it for some time), but since it's technically a separate package, I figured it was prudent to express an explicit dependency in the unlikely event that the Python package drops its dependency on pip in the future. It is probably unnecessary, though.

msarahan commented 8 years ago

That's a better explanation than I could have given. Thanks @minrk

pelson commented 8 years ago

Thanks @minrk. In which case, 👍