search

conda-forge / ipython-feedstock

A conda-smithy repository for ipython.
BSD 3-Clause "New" or "Revised" License
2 stars 34 forks source link

ipython v8.22.1 #210

Closed regro-cf-autotick-bot closed 8 months ago

regro-cf-autotick-bot commented 8 months ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection+grayskull shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection+grayskull but not in the meta.yaml:

Packages found in the meta.yaml but not found by source code inspection+grayskull:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/8007738835, please use this URL for debugging.

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 8 months ago

Pushed a couple requirement updates noted above

Could someone please look over these as well?

bollwyvl commented 8 months ago

I reckon we put pickleshare back in ... The failure modes are not pretty

On Thu, Feb 22, 2024, 15:48 jakirkham @.***> wrote:

Pushed a couple requirement updates noted above

Could someone please look over these as well?

— Reply to this email directly, view it on GitHub https://github.com/conda-forge/ipython-feedstock/pull/210#issuecomment-1960373176, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCRDC2AFUYJL52NWDB63YU64JHAVCNFSM6AAAAABDVJFQVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRQGM3TGMJXGY . You are receiving this because your review was requested.Message ID: @.***>

vyasr commented 8 months ago

Are you thinking of something like this? https://github.com/ipython/ipython/issues/14237

jakirkham commented 8 months ago

I reckon we put pickleshare back in ... The failure modes are not pretty

Am ok with that. Just couldn't tell if we just forgot to drop it here or if it was intentionally left in

Would also be interested to know what the failure modes are

Has there been discussion upstream about readding pickleshare as a hard dependency?

bollwyvl commented 8 months ago

Yeah, the referenced link is one of them. Basically a bunch of %%magics just fail, without saying why, didn't seem like something we wanted to deal with. Seemed pretty breaking when it landed. I haven't pushed on it upstream.

Carreau commented 7 months ago

Yeah I will probably reintroduce pickleshare as a hard dependency, but it's a dependency that is used only by IPython and I don't like it. It woudl be great to find an alternative.

Carreau commented 7 months ago

Yeah I will probably reintroduce pickleshare as a hard dependency, but it's a dependency that is used only by IPython and I don't like it. It woudl be great to find an alternative.