conda-forge / ipython-feedstock

A conda-smithy repository for ipython.
BSD 3-Clause "New" or "Revised" License
2 stars 34 forks source link

Bump/7.0.1 tests #58

Closed bollwyvl closed 6 years ago

bollwyvl commented 6 years ago

Checklist

Like #56 #57, this bumps to 7.0.1. I've also:

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 6 years ago

(Oh, and i was getting fails with test_history on linux, so skipping for now...)

blink1073 commented 6 years ago

Looks like that same test fails on osx. Also, there is some subtlety about skip and noarch: https://conda-forge.org/docs/meta.html#building-noarch-packages

bollwyvl commented 6 years ago

Yerp, let's pretend I let the second invocation of the tests run for demonstration purposes, and not that i forgot the windows selector :blush:


  File "/home/conda/feedstock_root/build_artifacts/ipython_1538102512878/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.5/site-packages/IPython/core/tests/test_history.py", line 113, in test_history
    newhist[3]])
AssertionError: Lists differ: [(1, [51 chars]rn test'), (1, 3, "b='€Æ¾÷ß'"), (2, 1, 'z=5'), (2, 3, "k='p'")] != [(1, [51 chars]rn test'), (1, 3, "b='€Æ¾÷ß'"), (2, 3, "k='p'"), (2, 4, 'z=5')]

First differing element 3:
(2, 1, 'z=5')
(2, 3, "k='p'")

  [(1, 1, 'a=1'),
   (1, 2, 'def f():\n    test = 1\n    return test'),
   (1, 3, "b='€Æ¾÷ß'"),
-  (2, 1, 'z=5'),
-  (2, 3, "k='p'")]
?                 ^

+  (2, 3, "k='p'"),
?                 ^

+  (2, 4, 'z=5')]
bollwyvl commented 6 years ago

Also, there is some subtlety about skip and noarch:

Right, but we have plenty of platform-specific deps to worry about, other noarch dilemmas aside. I've recently been encountering issues like the one seen on appveyor where an output directory with the full python version spec, < and all, tries to get created on windows, but haven't dug much deeper:

OSError: [WinError 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\bld\\ipython_1538087828414\\work_moved_ipython-7.0.1-py>=3_0_win-64_main_build_loop'
Command exited with code 1
bollwyvl commented 6 years ago

Here's a related report: https://github.com/conda/conda-build/issues/3105

bollwyvl commented 6 years ago

Well, that's OSX sorted!

bollwyvl commented 6 years ago

Hadn't seen this before:

There was an error checking the latest version of pip
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/site-packages/pip/_internal/utils/outdated.py", line 90, in pip_version_check
    state = SelfCheckState(cache_dir=options.cache_dir)
  File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/site-packages/pip/_internal/utils/outdated.py", line 25, in __init__
    self.statefile_path = os.path.join(cache_dir, "selfcheck.json")
  File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/posixpath.py", line 89, in join
    genericpath._check_arg_types('join', a, *p)
  File "/home/conda/feedstock_root/build_artifacts/ipython_1538104060228/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pla/lib/python3.5/genericpath.py", line 143, in _check_arg_types
    (funcname, s.__class__.__name__)) from None
TypeError: join() argument must be str or bytes, not 'bool'
bollwyvl commented 6 years ago

Great, now the long dark of the appveyor queue... really hope it passes there :P

blink1073 commented 6 years ago

@bollwyvl, nope ☹️

blink1073 commented 6 years ago

Ah curio is not available on Windows: https://github.com/conda-forge/curio-feedstock/blob/master/recipe/meta.yaml#L18

blink1073 commented 6 years ago

cf https://github.com/dabeaz/curio/issues/210

bollwyvl commented 6 years ago

Well, shucks. I'll test on some real iron right now and get that selector added and any test skips...

bollwyvl commented 6 years ago

Yep, tests worked the first time locally without any skips. :crossed_fingers:

bollwyvl commented 6 years ago

Added #44 while waiting...

blink1073 commented 6 years ago

Why not add you and I as maintainers while we're at it?

bollwyvl commented 6 years ago

Why not add yourself and me as maintainers while we're at it?

copy. killed the first appveyor job, since it would die anyway

bollwyvl commented 6 years ago

All green! Quick, someone press merge before it changes it's mind!

Carreau commented 6 years ago

All green! Quick, someone press merge before it changes it's mind!

Damn if only you were maintainer...

blink1073 commented 6 years ago

:tada: