ipython v7.1.1 - Githubissues

regro-cf-autotick-bot commented 5 years ago

It is very likely that the current package version for this feedstock is out of date. Notes and instructions for merging this PR:

Please check that the dependencies have not changed.
Please merge the PR only after the tests have passed.
Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

_{This PR was created by the cf-regro-autotick-bot.
The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.
Finally, feel free to drop us a line if there are any issues!}

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 5 years ago

Hooray, all CI running 10 minutes after announcement!

bollwyvl commented 5 years ago

Travis says

File "/Users/travis/miniconda3/conda-bld/ipython_1540674989531/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehol/lib/python3.6/site-packages/IPython/core/magics/osm.py", line 58, in _isexec_POSIX
    return file.is_file() and os.access(file.path, os.X_OK)
PermissionError: [Errno 13] Permission denied: '/usr/sbin/weakpass_edit'

Will investigate later, but some help with a real mac might help!

Carreau commented 5 years ago

Seem due to https://github.com/ipython/ipython/pull/11365

I can reproduce.

Carreau commented 5 years ago

    @skip_doctest
    def _isexec_POSIX(self, file):
        """
            Test for executible on a POSIX system
        """
        return file.is_file() and os.access(file.path, os.X_OK) # swap these so we test for access before testing whether it's a file.

bollwyvl commented 5 years ago

Ha, you beat me to it! Thanks!

On Sat, Oct 27, 2018, 17:36 Matthias Bussonnier notifications@github.com wrote:

@skip_doctest
def _isexec_POSIX(self, file):
    """
        Test for executible on a POSIX system
    """
    return file.is_file() and os.access(file.path, os.X_OK) # swap these so we test for access before testing whether it's a file.
— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/conda-forge/ipython-feedstock/pull/63#issuecomment-433657035, or mute the thread https://github.com/notifications/unsubscribe-auth/AACxRGMwCSOJo-ZHoSoTrHTNaiWu6ntCks5upNHogaJpZM4X9pfN .

Carreau commented 5 years ago

I'm probably no going to do a second release today.. maybe tomorrow. I guess we can add a patch to the recipe. We should also run the test on MacOs for the main repo.

bollwyvl commented 5 years ago

Yeah, upstream osx test sounds great... Will be interesting to see how that plays with the matrix...

Carreau commented 5 years ago

Also we can remove the dependency on simplegenerics in recipe.yml see ipython/ipython#11393

minrk commented 5 years ago

+ 💯 to osx tests on Travis on the main repo.

I really don't think we should be running the IPython test suite (or ~any Python package) on conda-forge. The only thing that should prevent IPython from shipping to conda is whether it's packaged correctly. If it installs and is importable, it shouldn't be relevant at all to conda-forge if the tests pass.

conda-forge / ipython-feedstock

ipython v7.1.1 #63