search

conda-forge / ipython-feedstock

A conda-smithy repository for ipython.
BSD 3-Clause "New" or "Revised" License
2 stars 34 forks source link

Use python-decorator. #7

Closed pelson closed 8 years ago

pelson commented 8 years ago

On conda-forge we have named it python-decorator to disambiguate. (PR just submitted, so CI may fail initially)

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

minrk commented 8 years ago

poked CI...

pelson commented 8 years ago

Thanks @minrk. All green. I'll try avoiding self-merging where possible :wink:

minrk commented 8 years ago

Sorry, forgot to come back after the CI finished.

minrk commented 8 years ago

BTW, I took a stab at addressing the PR list problem with this. Unfortunately, I have to ask conda-forge owners for read-only org permissions, due to weird scopes, so I can't see conda-forge repos on that list, yet.

jakirkham commented 8 years ago

Thanks @minrk. This is pretty neat.

Could I make a suggestion? Could we filter out staged-recipes? Anyone on the Core team is going to struggle with the SNR when that repo is included.

minrk commented 8 years ago

@jakirkham instead of blacklisting staged-recipes in particular, you can now specify a list of orgs or org/repos to exclude. I made staged-recipes excluded by default as an example.

jakirkham commented 8 years ago

Excellent was thinking that you would pick the better software engineering approach. 😉 Sounds totally sensible to me.