search

conda-forge / ipython-feedstock

A conda-smithy repository for ipython.
BSD 3-Clause "New" or "Revised" License
2 stars 34 forks source link

Suggestion: depend on matplotlib-base instead of matplotlib #96

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 4 years ago

I noticed that this recipe depends on matplotlib instead of matplotlib-base. Unless you need pyqt, recipes should depend only on matplotlib-base. This PR makes this change. Notes and instructions for merging this PR:

  1. Make sure that the recipe can indeed only depend on matplotlib-base.
  2. Please merge the PR only after the tests have passed.
  3. Feel free to push to the bot's branch to update this PR if needed.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/14463, please use this URL for debugging

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 4 years ago

I am :-1: to adopting this, as its a test-time dependency, so not making anyone's life much worse, and I'd just as soon test with the qt nightmare in there.

jakirkham commented 4 years ago

@CJ-Wright @beckermr, what do you think about skipping these when it is a test only dependency?

beckermr commented 4 years ago

I agree that test time deps are fine in principle since the main issue is avoiding pulling in big qt packages when they are not needed into envs at runtime. The only issue I can see is that a test runs with qt and then a package breaks at runtime without it.

I'll leave this in the hands of the @conda-forge/ipython maintainers to weigh the choice.

beckermr commented 4 years ago

I do think we should send out all PRs for any dep, but I am ok if the PR is closed without merging. That won't break the bot and the bot shouldn't reissue the PR either even if it is closed without merging.

jakirkham commented 4 years ago

Yeah I guess if closing it clears feedstock from the migration it doesn't hurt to send the PR anyways. No other way to know whether maintainers will accept it or not.

mariusvniekerk commented 4 years ago

Closing the PR would just mark it as "done" from the bot's point of view