Closed regro-cf-autotick-bot closed 4 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@bjlittle we are slowly implementing pip check
for conda-forge builds. We can comment it out here but the failure here should be fixed by https://github.com/SciTools/cf-units/pull/156
@ocefpaf We raised a different PR to add the Iris 2.4 release (#54) as we thought we had to remove iris_rc
from the channel targets. Is this correct? We also found that the License appeared to be wrong (see #54 for more information)
@ocefpaf We raised a different PR to add the Iris 2.4 release (#54) as we thought we had to remove
iris_rc
from the channel targets. Is this correct?
Correct. I actually failed to create a branch for it and this should not be there anyway.
We also found that the License appeared to be wrong (see #54 for more information)
Is that change new? I was pretty sure that iris
had a dual license.
Closing this in favor of #54. Note that the pip check
test is desirable and will be mandatory soon. We still need to fix cf_units to allow that test here.
Is that change new? I was pretty sure that iris had a dual license.
Iris is still on the LGPL license (although would eventually like to move to BSD3). I've noticed there is a bit of inconsistency between how the different scitools packages define the license in their conda-forge recipes, despite (mostly) all having the same license. For example cartopy includes COPYING as the license file, whereas cf_units includes COPYING.LESSER
Conda allows for the license file to be "a single filename or a YAML list for multiple license files" so perhaps what we should be doing is providing both "COPYING" and "COPYING.LESSER"
Conda allows for the license file to be "a single filename or a YAML list for multiple license files" so perhaps what we should be doing is providing both "COPYING" and "COPYING.LESSER"
I'm pretty sure we can use multiple license now.
It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:
license_file
is packagedNote that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/14536, please use this URL for debugging