noarch iris - Githubissues

conda-forge / iris-feedstock

A conda-smithy repository for iris.

BSD 3-Clause "New" or "Revised" License

0 stars 17 forks source link

noarch iris #75

Closed bjlittle closed 2 years ago

bjlittle commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] ~Reset the build number to 0 (if the version changed)~
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bjlittle commented 2 years ago

@conda-forge-admin, please rerender

bjlittle commented 2 years ago

@ocefpaf I don't know the best practice here... but in your opinion is it okay to make iris a noarch package without bumping the version (only bumping the build number).

Note, we're due to release iris 3.2 most likely in January 2022, so should we wait until then to do this instead?

bjlittle commented 2 years ago

@conda-forge-admin, please rerender

bjlittle commented 2 years ago

@jamesp Are you okay being added as an iris package maintainer

ocefpaf commented 2 years ago

@ocefpaf I don't know the best practice here... but in your opinion is it okay to make iris a noarch package without bumping the version (only bumping the build number).

It is fine to just bump the build number. No need for a new version b/c this is 100% related to the build and not the version.

@jamesp Are you okay being added as an iris package maintainer

We cannot merge this unless @jamesp gives an OK.

jamesp commented 2 years ago

@ocefpaf @bjlittle yes good with me, thanks!

ocefpaf commented 2 years ago

Closing and reopening to toggle the CIs.

ocefpaf commented 2 years ago

We are seeing a similar breakage in other packages. Newer setuptools and pip are not happy with the newline in the description.