conda-forge / iris-feedstock

A conda-smithy repository for iris.
BSD 3-Clause "New" or "Revised" License
0 stars 17 forks source link

Recipe updates for v3.4.1 #89

Closed trexfeathers closed 1 year ago

trexfeathers commented 1 year ago

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

trexfeathers commented 1 year ago

@conda-forge-admin, please rerender

trexfeathers commented 1 year ago

@valeriupredoi does conda-forge/conda-forge-repodata-patches-feedstock#358 mean anything for this release? I'm assuming not?

trexfeathers commented 1 year ago

Did you also add python=3.11 as supported by the new iris?

Not explicitly - that would go beyond the minimal patch we are aiming for. We won't stop you trying Python 3.11, but can't guarantee it will work.

valeriupredoi commented 1 year ago

@valeriupredoi does conda-forge/conda-forge-repodata-patches-feedstock#358 mean anything for this release? I'm assuming not?

not for this one it doesn't - the patch stops at iris=3.4.0 and I think it's best you guys keep it that way unless you want to re-release 3.4.0 with the new segfault slayer that this version contains

valeriupredoi commented 1 year ago

Did you also add python=3.11 as supported by the new iris?

Not explicitly - that would go beyond the minimal patch we are aiming for. We won't stop you trying Python 3.11, but can't guarantee it will work.

excellent! We'll plug 3.11 only when iris-esmf-regrid will support it (I think it's still 3.10-limited atm)

trexfeathers commented 1 year ago

Thanks @stephenworsley!