search

conda-forge / isce3-feedstock

A conda-smithy repository for isce3.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

vendoring files from scipy? #18

Closed beckermr closed 2 years ago

beckermr commented 2 years ago

Something in this build is vendoring files from scipy according to our bots: https://github.com/conda-forge/artifact-validation/issues/769

Can you all look at this @conda-forge/isce3?

rtburns-jpl commented 2 years ago 
tree lib/python3.7/site-packages/scipy/                                       
lib/python3.7/site-packages/scipy/
└── stats
    └── __pycache__
        └── _page_trend_test.cpython-37-pytest-6.2.5.pyc

2 directories, 1 file

I guess it's just the pycache that's created during unit tests. Shouldn't this be stripped out by the feedstock build? What do I need to do to get rid of it?

beckermr commented 2 years ago

Ahhhh. Do you run the tests during the build or test phase?

beckermr commented 2 years ago

Looks like build phase. conda-build won't remove those. If you can run them during the test phase that will fix it. Otherwise removing them by hand is fine.

rtburns-jpl commented 2 years ago

Oh I see, thanks! So instead of calling ctest in build.sh, I should put in meta.yaml:

test:
  commands:
     ctest

Is that right?

beckermr commented 2 years ago

Yes. You umay need to request that conda build specific source files when doing this as well.