Add missing hdf5 host dependency

conda-forge / isce3-feedstock

A conda-smithy repository for isce3.

BSD 3-Clause "New" or "Revised" License

2 stars 2 forks source link

Add missing hdf5 host dependency #39

Closed rtburns-jpl closed 1 year ago

rtburns-jpl commented 1 year ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

rtburns-jpl commented 1 year ago

@conda-forge-admin, please rerender

gmgunter commented 1 year ago

@rtburns-jpl it looks like h5py is listed as both a "host" and "run" dependency.

https://github.com/conda-forge/isce3-feedstock/blob/ae1d230ed90c26aca5c3d4cfad780b8f6de6b24e/recipe/meta.yaml#L37

https://github.com/conda-forge/isce3-feedstock/blob/ae1d230ed90c26aca5c3d4cfad780b8f6de6b24e/recipe/meta.yaml#L46

Maybe that could be confusing the algorithm that's used to determine the runtime environment spec?

rtburns-jpl commented 1 year ago

I believe that is unrelated. Our python dependencies need to be listed in "host" and "run" because our python tests run in build.sh. Run deps aren't available in build.sh, and host deps don't get propagated to run if they're python packages, so we have to list them twice.

gmgunter commented 1 year ago

OK thanks for the clarification.

host deps don't get propagated to run if they're python packages

weird...