conda-forge / isce3-feedstock

A conda-smithy repository for isce3.
BSD 3-Clause "New" or "Revised" License
2 stars 2 forks source link

Rebuild for CUDA 12 w/arch + Windows support #64

Closed regro-cf-autotick-bot closed 1 month ago

regro-cf-autotick-bot commented 4 months ago

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems see this issue. Please feel free to raise any issues encountered there. Thank you! :pray:


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 1 month ago

@conda-forge-admin , please re-render

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

jakirkham commented 1 month ago

@conda-forge-admin , please re-render

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/isce3-feedstock/actions/runs/10367759331.

jakirkham commented 1 month ago

The import test failed on CI;

import: 'isce3'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/isce3_1723543707699/test_tmp/run_test.py", line 2, in <module>
    import isce3
  File "/home/conda/feedstock_root/build_artifacts/isce3_1723543707699/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/isce3/__init__.py", line 2, in <module>
    from .ext import extisce3
  File "/home/conda/feedstock_root/build_artifacts/isce3_1723543707699/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_/lib/python3.10/site-packages/isce3/ext/__init__.py", line 3, in <module>
    from . import isce3 as extisce3
ImportError: libcudart.so.12: cannot open shared object file: No such file or directory

However this is expected behavior as we don't have a GPU on CI

Would recommend skipping this test on CUDA builds

jakirkham commented 1 month ago

Also needs a build/number bump

rtburns-jpl commented 1 month ago

Will this bump require users to upgrade to CUDA 12 drivers? I hadn't focused on this since most isce3 users are still on the CUDA 11.x series.

jakirkham commented 1 month ago

Will this bump require users to upgrade to CUDA 12 drivers? I hadn't focused on this since most isce3 users are still on the CUDA 11.x series.

This adds CUDA 12 packages in addition to CUDA 11 packages. So CUDA 11 packages are still being built

jakirkham commented 1 month ago

Looks fine to me, but I pushed some of the fixes 😄

Will defer to you 😉

jakirkham commented 1 month ago

Thanks Ryan! 🙏