v0.3.14 take 2 - Githubissues

conda-forge / jax-feedstock

A conda-smithy repository for jax.

BSD 3-Clause "New" or "Revised" License

6 stars 20 forks source link

v0.3.14 take 2 #94

Closed ngam closed 2 years ago

ngam commented 2 years ago

Fixes #93

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ngam commented 2 years ago

@conda-forge-admin, please rerender.

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/jax-feedstock/actions/runs/2570295481.

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/jax-feedstock/actions/runs/2578986996.

ocefpaf commented 2 years ago

@ngam LGTM. Do you want to do anything else, add yourself as a maintainer maybe ;-p, before we merge?

ngam commented 2 years ago

That's a good idea, I also want to try to run their test suite here

ocefpaf commented 2 years ago

That's a good idea, I also want to try to run their test suite here

Please ping me when you are done. Thanks for fixing this BTW!

ngam commented 2 years ago

@conda-forge-admin, please rerender.

ngam commented 2 years ago

That's a good idea, I also want to try to run their test suite here

Please ping me when you are done. Thanks for fixing this BTW!

I will add the tests later. We can merge this for now. I want to look into their test suite more first and do some local runs. I will get it to by next week or so...

ngam commented 2 years ago

(It's not rerendeirng for some reason... :/)

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/jax-feedstock/actions/runs/2583882030.