Abseil dual migration - Githubissues

conda-forge / jaxlib-feedstock

A conda-smithy repository for jaxlib.

BSD 3-Clause "New" or "Revised" License

16 stars 24 forks source link

Abseil dual migration #102

Closed hmaarrfk closed 2 years ago

hmaarrfk commented 2 years ago

Needs: https://github.com/conda-forge/bazel-feedstock/pull/125

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 2 years ago

@conda-forge-admin please restart cis

hmaarrfk commented 2 years ago

I believe that this is ready for review. Unpinning and moving things forward seemed to work. the last I checked, there were a few failed builds before I rebased due to 400 or 404 errors.

ngam commented 2 years ago

Thanks, just so that I understand migrations better going forward. The idea is that one of these grpc_cpps is gonna be dropped eventually?

hmaarrfk commented 2 years ago

yes. thought right now tensorflow can't build with the new one. So once tensorflow can, we will move it forward. It seems that 2.9.0 is a maybe.

ericmjl commented 2 years ago

Looks like all checks pass. I have to admit, the PR is large enough that I don't have enough bandwidth to review it in detail, so I'll defer to both of you. Should we merge?

hmaarrfk commented 2 years ago

I think if you trust your tests this should just be good. The commits, one at a time, are really small (except for the rerender)

ngam commented 2 years ago

so I'll defer to both of you. Should we merge?

I'd vote to merge, as this doesn't change much fundamentally imo (just more variants). However, I'd give xhochy and others a few days to have a chance to look first, but also we might need to consider tf 2.9.x https://github.com/conda-forge/tensorflow-feedstock/pull/240

ngam commented 2 years ago

I think if you trust your tests this should just be good

This is definitely a healthy stock. I would trust the tests to a large extent

hmaarrfk commented 2 years ago

xhochy has been involved in the abseil and grpc effort with me. You can ping if you want, though I presume he is just busy with other stuff.

xhochy commented 2 years ago

Though sometimes he has time to look at this ;)