search

conda-forge / jaxlib-feedstock

A conda-smithy repository for jaxlib.
BSD 3-Clause "New" or "Revised" License
16 stars 24 forks source link

Switch to new libabeil builds #144

Closed h-vetinari closed 2 years ago

h-vetinari commented 2 years ago

See https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/3181

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ngam commented 2 years ago

Just one question @h-vetinari. Does this officially decouple grpc and libabseil?

h-vetinari commented 2 years ago

Just one question @h-vetinari. Does this officially decouple grpc and libabseil?

Yes, that is correct, because libabseil is not part of the same zip_keys. The decoupling was the goal after the abseil migration anyway. My plan is to then restart (or if necessary, redo) the grpc 1.47 migration to get consistent everywhere, and then move to 1.48

ngam commented 2 years ago

Yep, sounds good to me! I just wanted to double-check. If you want me to add you here as a maintainer to do testing, let me know. Just fyi, the builds here take on the order of 4 hours, usually the osx ones take closer to 5 hours.

h-vetinari commented 2 years ago

Thanks, that doesn't seem necessary for now. You can ping me of course, but so far this seems in good hands with you. 🙃

For the CI runtime question, I usually just slap on an automerge and move on. 🤷

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!