conda-forge / jaxlib-feedstock

A conda-smithy repository for jaxlib.
BSD 3-Clause "New" or "Revised" License
16 stars 24 forks source link

WIP: Depend on our own abseil again #193

Open h-vetinari opened 1 year ago

h-vetinari commented 1 year ago

Something I couldn't pull off in #192, perhaps someone can help.

The issue is that jaxlib calls another bazel build for the vendored xla, which then does not pick up the correct @com_google_absl anymore. That's despite xla having logic for processing TF_SYSTEM_LIBS, but it seems bazel isolation doesn't pass the variable down. I tried various things like

--- a/recipe/build.sh
+++ b/recipe/build.sh
@@ -74,6 +74,7 @@ else
     EXTRA="${CUDA_ARGS:-}"
 fi
 ${PYTHON} build/build.py \
+    --bazel_options=--action_env=TF_SYSTEM_LIBS=${TF_SYSTEM_LIBS} \
     --target_cpu_features default \
     --enable_mkl_dnn \
     ${EXTRA}

and

--- a/recipe/build.sh
+++ b/recipe/build.sh
@@ -74,6 +74,7 @@ else
     EXTRA="${CUDA_ARGS:-}"
 fi
 ${PYTHON} build/build.py \
+    --bazel_options=--override_repository=com_google_absl=$PREFIX/lib \
     --target_cpu_features default \
     --enable_mkl_dnn \
     ${EXTRA}

but to no success.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.