conda-forge / jaxlib-feedstock

A conda-smithy repository for jaxlib.
BSD 3-Clause "New" or "Revised" License
16 stars 24 forks source link

jaxlib v0.4.18 #199

Closed regro-cf-autotick-bot closed 12 months ago

regro-cf-autotick-bot commented 1 year ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #194 Closes: #195 Closes: #198

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6438589928, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xhochy commented 1 year ago

Depends on https://github.com/conda-forge/bazel-toolchain-feedstock/pull/14

h-vetinari commented 1 year ago

Is something about our CUDA patch going wrong?

ERROR: $BUILD_PREFIX/share/bazel/a688ce8bb712e8d46b7b7a0d359c3a2b/external/xla/xla/pjrt/gpu/BUILD:211:11: Label '@xla//xla/service/gpu:gpu_compiler' is duplicated in the 'deps' attribute of rule 'se_gpu_pjrt_compiler'
ERROR: $BUILD_PREFIX/share/bazel/a688ce8bb712e8d46b7b7a0d359c3a2b/external/xla/xla/python/BUILD:1065:11: Target '@xla//xla/pjrt/gpu:se_gpu_pjrt_client' contains an error and its package is in error and referenced by '@xla//xla/python:xla_extension_library'
ERROR: Analysis of target '//jaxlib/tools:build_wheel' failed; build aborted: 
INFO: Elapsed time: 29.519s
xhochy commented 12 months ago

Bisecting this:

xhochy commented 12 months ago
e84be656fc4cef719634e925575eab4a05fca77e is the first bad commit
commit e84be656fc4cef719634e925575eab4a05fca77e
Author: jax authors <no-reply@google.com>
Date:   Sat Sep 23 01:16:52 2023 -0700

    Update XLA dependency to use revision
    http://github.com/openxla/xla/commit/fbd9c73f0f6078d9971cd17b79cb4a3c33235286.

    PiperOrigin-RevId: 567820717

 third_party/xla/workspace.bzl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
xhochy commented 12 months ago

Bisecting XLA:

5f604d4f519d9329ef9524549e78f5cdeacad4a1 is the first bad commit
commit 5f604d4f519d9329ef9524549e78f5cdeacad4a1
Author: Shixin Li <shixinli@google.com>
Date:   Fri Sep 22 13:05:26 2023 -0700

    Enable cross compilation for PJRT GPU compiler:
    1. StreamExecutorGpuCompiler compiles w/o client.
    2. Add StreamExecutorGpuExecutable (the unloaded pjrt executable).
    3. Load StreamExecutorGpuExecutable to PjRtLoadedExecutable through `Load` API.

    PiperOrigin-RevId: 567697879

 xla/client/local_client.h                          |   2 +
 xla/pjrt/BUILD                                     |  15 ++
 xla/pjrt/gpu/BUILD                                 |  95 +++++++++++-
 xla/pjrt/gpu/se_gpu_pjrt_client.cc                 |  45 ++++++
 xla/pjrt/gpu/se_gpu_pjrt_client.h                  |   5 +
 xla/pjrt/gpu/se_gpu_pjrt_compiler.cc               | 108 +++++++++++++
 xla/pjrt/gpu/se_gpu_pjrt_compiler.h                |  15 ++
 xla/pjrt/gpu/se_gpu_pjrt_compiler_aot_test.cc      | 167 +++++++++++++++++++++
 xla/pjrt/gpu/se_gpu_pjrt_compiler_test.cc          |   1 +
 xla/pjrt/pjrt_stream_executor_client.cc            |  39 ++---
 xla/pjrt/pjrt_stream_executor_client.h             |   1 +
 xla/pjrt/stream_executor_unloaded_executable.cc    |  31 ++++
 xla/pjrt/stream_executor_unloaded_executable.h     |  78 ++++++++++
 xla/pjrt/stream_executor_unloaded_executable.proto |  28 ++++
 xla/service/gpu/BUILD                              |  13 ++
 xla/service/gpu/gpu_compiler.cc                    |  15 --
 xla/service/gpu/gpu_compiler.h                     |  13 +-
 xla/service/gpu/gpu_target_config.cc               |  38 +++++
 xla/service/gpu/gpu_target_config.h                |  41 +++++
 19 files changed, 703 insertions(+), 47 deletions(-)
 create mode 100644 xla/pjrt/gpu/se_gpu_pjrt_compiler_aot_test.cc
 create mode 100644 xla/pjrt/stream_executor_unloaded_executable.cc
 create mode 100644 xla/pjrt/stream_executor_unloaded_executable.h
 create mode 100644 xla/pjrt/stream_executor_unloaded_executable.proto
 create mode 100644 xla/service/gpu/gpu_target_config.cc
 create mode 100644 xla/service/gpu/gpu_target_config.h
xhochy commented 12 months ago

Upstream has fixed this in https://github.com/openxla/xla/commit/9938bdbbf34a4098856ef387e3f1c53398d3f1e1

xhochy commented 12 months ago

We're now hitting https://github.com/openxla/xla/pull/6291

h-vetinari commented 12 months ago

Amazing detective work! 💪

xhochy commented 12 months ago

Now fails with

# Execution platform: @local_execution_config_platform//:platform
external/xla/xla/backends/profiler/gpu/cupti_tracer.cc: In member function 'tsl::Status xla::profiler::CuptiTracer::ProcessActivityBuffer(CUcontext, uint32_t, uint8_t*, size_t)':
external/xla/xla/backends/profiler/gpu/cupti_tracer.cc:2177:34: error: 'TF_CUPTI_HAS_CHANNEL_ID' was not declared in this scope
 2177 |           AddKernelActivityEvent<TF_CUPTI_HAS_CHANNEL_ID>(
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~
external/xla/xla/backends/profiler/gpu/cupti_tracer.cc:2178:76: error: no matching function for call to 'AddKernelActivityEvent<<expression error> >(xla::profiler::CuptiTraceCollector*&, xla::profiler::{a
nonymous}::CuptiActivityKernelTy*)'
 2178 |               collector_, reinterpret_cast<CuptiActivityKernelTy *>(record));
      |                                                                            ^
external/xla/xla/backends/profiler/gpu/cupti_tracer.cc:747:6: note: candidate: 'template<bool cupti_has_channel_id, class CuptiActivityKernel> void xla::profiler::{anonymous}::AddKernelActivityEvent(xla::
profiler::CuptiTraceCollector*, const CuptiActivityKernel*)'
  747 | void AddKernelActivityEvent(CuptiTraceCollector *collector,
      |      ^~~~~~~~~~~~~~~~~~~~~~
external/xla/xla/backends/profiler/gpu/cupti_tracer.cc:747:6: note:   template argument deduction/substitution failed:
external/xla/xla/backends/profiler/gpu/cupti_tracer.cc:2178:76: error: template argument 1 is invalid
 2178 |               collector_, reinterpret_cast<CuptiActivityKernelTy *>(record));
      |                                                                            ^
external/xla/xla/backends/profiler/gpu/cupti_tracer.cc: In function 'const char* xla::profiler::GetTraceEventTypeName(const xla::profiler::CuptiTracerEventType&)':
external/xla/xla/backends/profiler/gpu/cupti_tracer.cc:1858:1: warning: control reaches end of non-void function [-Wreturn-type]
 1858 | }
      | ^
conda-forge-webservices[bot] commented 12 months ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-webservices[bot] commented 12 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xhochy commented 12 months ago

Needs at least https://github.com/conda-forge/bazel-toolchain-feedstock/pull/15 and some more changes

xhochy commented 12 months ago

CUDA on aarch64 never compiled successfully. Skipping this for now.

github-actions[bot] commented 12 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!