conda-forge / jaxlib-feedstock

A conda-smithy repository for jaxlib.
BSD 3-Clause "New" or "Revised" License
16 stars 24 forks source link

Use build instead of number as variable for build number #267

Closed traversaro closed 3 months ago

traversaro commented 3 months ago

I noticed that recent rebuild were not bumping the build number, see for example:

I looked into this, and apparently the bot assumes that the variable used to set the build number needs to be called either build or build_number, but not number as done in this recipe, see https://github.com/regro/cf-scripts/blob/bc57282361ba7437a46ee7ddde0783b94f1c1bc8/conda_forge_tick/update_recipe/build_number.py#L5-L11 .

I choose to use build as it is the variable name more used in conda-forge and used in the knowledge base: https://github.com/conda-forge/conda-forge.github.io/blob/26db656d1b1828b14fa24f16820ba30ec31c387f/docs/maintainer/knowledge_base.md#L968 .

Checklist

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 3 months ago

I did not re-rendered or bumped the build number as this change does not change the generated recipe.

xhochy commented 3 months ago

Done in https://github.com/conda-forge/jaxlib-feedstock/pull/250

traversaro commented 3 months ago

Done in #250

Perfect, thanks!