Bump cudnn to 9 - Githubissues

conda-forge / jaxlib-feedstock

A conda-smithy repository for jaxlib.

BSD 3-Clause "New" or "Revised" License

16 stars 24 forks source link

Bump cudnn to 9 #278

Closed traversaro closed 1 month ago

traversaro commented 1 month ago

Test if compilation works, waiting for https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/6310, useful to fix https://github.com/conda-forge/jax-feedstock/issues/149 and https://github.com/conda-forge/jaxlib-feedstock/issues/277 .

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

traversaro commented 1 month ago

@conda-forge-admin, please rerender.

traversaro commented 1 month ago

After rerenderign the linux build disappeared, probably it is related to cirun?

traversaro commented 1 month ago

The current macos builds are not useful, closing the PR so hopefully they will stop.

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

No valid build backend found for Python recipe for package jaxlib using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

ngam commented 1 month ago

@conda-forge/core, is it for someone to enable the cirun to see if they pass this PR? I am not sure if the approved list is open for anyone to join, so if there's a place to request access, I'd be happy to join and avoid pinging you en masse. Thanks

h-vetinari commented 1 month ago

I am not sure if the approved list is open for anyone to join, so if there's a place to request access, I'd be happy to join

Yes, you can join, if you follow the instructions on that repo.

ngam commented 1 month ago

xref https://github.com/Quansight/open-gpu-server/pull/38

ngam commented 1 month ago

Thanks @xhochy --- do you think this is good to go or should we wait the migration bot?

@traversaro any objections before we merge?

traversaro commented 1 month ago

@traversaro any objections before we merge?

No objections on my side, thanks a lot for handling this!

xhochy commented 1 month ago

I would prefer to merge #279 if it passes straight-away.