conda-forge / jaxlib-feedstock

A conda-smithy repository for jaxlib.
BSD 3-Clause "New" or "Revised" License
16 stars 24 forks source link

Rebuild for python 3.13 #280

Open regro-cf-autotick-bot opened 1 month ago

regro-cf-autotick-bot commented 1 month ago

This PR has been triggered in an effort to update python313.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by - please use this URL for debugging.

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

xhochy commented 1 month ago

@ngam Why did you mark this as draft? I would expect it to work with some dependency tweaks.

xhochy commented 1 month ago

It is missing the necessary files for the HERMETIC_PYTHON implementation and thus runs into some kind of import cycle.

ngam commented 1 month ago

Why did you mark this as draft? I would expect it to work with some dependency tweaks.

Precisely this. The PR needs additional work. I thought we might not get to it before something else happens (a version update, etc.), but if we get to it earlier, we can mark the PR as ready...

I will try to look into it soon

xhochy commented 14 hours ago

Seems like 0.4.34 will support 3.13. I'm looking at building it now