jaxsim v0.5.0 - Githubissues

flferretti commented 5 hours ago

Fixes #10 Fixes #11

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-admin commented 5 hours ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
- For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
- If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

flferretti commented 4 hours ago

# [...]
chex 0.1.87 requires setuptools, which is not installed.

@traversaro this looks strange to me. Should we really add setuptools in test requirements?

traversaro commented 1 hour ago

It seems that is a bug of chex upstream. Probably we can at least patch it in the feedstock.

traversaro commented 1 hour ago

But yes the quickest solution is to add setuptools to test dependencies.

conda-forge / jaxsim-feedstock