Add `scipy` as additional visualization dependency

conda-forge / jaxsim-feedstock

A conda-smithy repository for jaxsim.

BSD 3-Clause "New" or "Revised" License

2 stars 3 forks source link

Add `scipy` as additional visualization dependency #6

Closed flferretti closed 4 months ago

flferretti commented 4 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

flferretti commented 4 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/jaxsim-feedstock/actions/runs/9939907017.

flferretti commented 4 months ago

JAX already installs scipy (https://conda-metadata-app.streamlit.app/~/+/?q=conda-forge%2Fnoarch%2Fjax-0.4.28-pyhd8ed1ab_0.conda#dependencies), but I believe it is better to be on the safe side

diegoferigo commented 4 months ago

JAX already installs scipy (https://conda-metadata-app.streamlit.app/~/+/?q=conda-forge%2Fnoarch%2Fjax-0.4.28-pyhd8ed1ab_0.conda#dependencies), but I believe it is better to be on the safe side

Even better if plain scipy is a direct dependency of jax. In any case, yep it's always reasonable to explicitly list all the direct dependencies. And the identification of such dependencies is also one of the reason of the current formatting of the imports.