PR: Enable aarch64 build

conda-forge / jellyfish-feedstock

A conda-smithy repository for jellyfish.

BSD 3-Clause "New" or "Revised" License

1 stars 10 forks source link

PR: Enable aarch64 build #33

Closed dalthviz closed 2 years ago

dalthviz commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Hi @anthchirp , @blabalme and @pmlandwehr !

spyder has now as dependency jellyfish but for the aarch64 build jellyfish is missing. Could it be possible to enable the aarch64 builds for jellyfish? Hope you can approve the proposed changes here!

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dalthviz commented 2 years ago

@conda-forge-admin, please rerender

Anthchirp commented 2 years ago

Hi, the way to do this normally is to create a PR to add a line with your package name into https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/master/recipe/migrations/arch_rebuild.txt which will trigger PRs on the package and all its dependencies for the entire dependency tree.

Anthchirp commented 2 years ago

added PR https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/2232

I am not 100% sure this is functionally exactly equivalent to your PR, so if someone else wants to merge this PR in the meantime please go ahead.

dalthviz commented 2 years ago

Thank you for the help @Anthchirp ! I didn't know about using conda-forge-pinning-feedstock to support aarch64 across all the dependencies (that's quite handy!)

ccordoba12 commented 2 years ago

added PR conda-forge/conda-forge-pinning-feedstock#2232

I don't know if this will work because all the current Spyder dependencies support aarch64. So perhaps we need to add jellyfish there?

I am not 100% sure this is functionally exactly equivalent to your PR, so if someone else wants to merge this PR in the meantime please go ahead.

@conda-forge/core, what do you think about this one? I think the regro bot will do exactly the same that @dalthviz did here manually.

Anthchirp commented 2 years ago

According to https://conda-forge.org/status/#aarch64andppc64leaddition, spyder is currently waiting on

tzlocal, which itself is waiting on
- https://github.com/conda-forge/pytz-deprecation-shim-feedstock/pull/7
pyqt, which itself is waiting on
- https://github.com/conda-forge/qt-feedstock/pull/184

I see from the spyder PR that you are adding the dependency in the same PR as adding the new architecture - just skip the new architecture in the spyder-PR, and merge it if successful, then the bot should pick up the new dependencies automatically. Then add aarch in a separate PR.

Anthchirp commented 2 years ago

Given that the dependency is not currently in the spyder-recipe I'll get jellyfish added directly 👍

beckermr commented 2 years ago

Just piping in here to say that the bot stuff is for convenience and ease of use. It is totally fine to enable things by hand if people so desire!

ccordoba12 commented 2 years ago

Thanks for your help @Anthchirp!