search

conda-forge / jplephem-feedstock

A conda-smithy repository for jplephem.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

MNT: Re-rendered with conda-smithy 2.0.0 #6

Closed jochym closed 7 years ago

conda-forge-linter commented 7 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jochym commented 7 years ago

@jakirkham or @brandon-rhodes would you merge this re-rendering? Skyfield feedstock have jplephem as dependency and I cannot release it for py3.6

jakirkham commented 7 years ago

Sure. Though I'd add that if this dependency is very important to you, it might be worthwhile to add yourself as a maintainer so that you can address this stuff more directly.

jochym commented 7 years ago

How about now @jakirkham ?

jochym commented 7 years ago

@jakirkham is there anything still missing with this recipe preventing the merge, or you just busy?

jakirkham commented 7 years ago

Looks fine. Was kind of hoping @brandon-rhodes and/or @Juanlu001 would weigh in given it is their feedstock. 😉

jochym commented 7 years ago

Unfortunatly @brandon-rhodes is probably too busy - ha was warning me about it when I included him as a maintainer in skyfield feedstock. Maybe @Juanlu001 can pick up the mantle?

brandon-rhodes commented 7 years ago

I also lack any context on this particular diff's changes, so I can't meaningfully review the changed lines of code. So, yes, please proceed without me! :)

jochym commented 7 years ago

These are just re-rendering of the recipe to update the build setup and enable build for python 3.6.

astrojuanlu commented 7 years ago

Oops! Missed this one, merging right away :) Thanks @jochym!

jakirkham commented 7 years ago

Thanks @Juanlu001.

jochym commented 7 years ago

Thanks @Juanlu001