search

conda-forge / julia-feedstock

A conda-smithy repository for julia.
BSD 3-Clause "New" or "Revised" License
23 stars 32 forks source link

julia v1.7.2 #188

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :( Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1809122063, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mkitti commented 2 years ago 
Applying patch: /home/conda/recipe_root/patches/0001-disable-testing-Vararg-Int-N-where.patch with args:
['-Np1', '-i', '/tmp/tmppil58e59/0001-disable-testing-Vararg-Int-N-where.patch.native', '--binary']
checking file test/core.jl
Hunk #1 FAILED at 3516.
1 out of 1 hunk FAILED
Warning: failed to download source.  If building, will try again after downloading recipe dependencies.
Error was: 
Command '['/opt/conda/bin/patch', '--no-backup-if-mismatch', '--batch', '-Np1', '-i', '/tmp/tmppil58e59/0001-disable-testing-Vararg-Int-N-where.patch.native', '--binary', '--dry-run']' returned non-zero exit status 1.
Traceback (most recent call last):
  File "/opt/conda/bin/conda-mambabuild", line 10, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.9/site-packages/boa/cli/mambabuild.py", line 239, in main
    call_conda_build(action, config)
  File "/opt/conda/lib/python3.9/site-packages/boa/cli/mambabuild.py", line 211, in call_conda_build
    result = api.build(
  File "/opt/conda/lib/python3.9/site-packages/conda_build/api.py", line 186, in build
    return build_tree(
  File "/opt/conda/lib/python3.9/site-packages/conda_build/build.py", line 3088, in build_tree
    packages_from_this = build(metadata, stats,
  File "/opt/conda/lib/python3.9/site-packages/conda_build/build.py", line 2138, in build
    try_download(m, no_download_source=False, raise_error=True)
  File "/opt/conda/lib/python3.9/site-packages/conda_build/render.py", line 662, in try_download
    raise RuntimeError("Failed to download or patch source. Please see build log for info.")
RuntimeError: Failed to download or patch source. Please see build log for info.
mkitti commented 2 years ago

We probably just need to backport a change from https://github.com/conda-forge/julia-feedstock/commit/6c59b130f45dad8616e00d768ef4ccc6da6ab948 to remove some of the patches.

ngam commented 2 years ago

We probably just need to backport a change from 6c59b13 to remove some of the patches.

Indeed: https://github.com/JuliaLang/julia/compare/v1.7.1...v1.7.2

ngam commented 2 years ago

@mkitti, I backported the whole thing with minor modifications --- or should we hold off on some of the more involved changes?

ngam commented 2 years ago

@conda-forge-admin, please rerender

ngam commented 2 years ago

CC @zklaus @valeriupredoi @MilesCranmer @fingolfin some changes in this PR. Let us know if you find anything of interest and we are here to respond speedily :)

Also, note! We are only weeks away from 1.8.0 it seems... so expect some more activity on the packaging front and so on.

@MilesCranmer, we should probably rebuild downstream to see how things go, I will start PRs in the new feedstocks

mkitti commented 2 years ago

Feature freeze for 1.8 is in a week.

MilesCranmer commented 2 years ago

LGTM! The openlibm fix was the main issue earlier; glad that is fixed

mkitti commented 2 years ago

Oh I see, the tests never actually passed.

ngam commented 2 years ago

How did that happen???? UGH!

valeriupredoi commented 2 years ago

cheers guys! All good at our end with julia 1.7.2 h989b2f6_0 conda-forge/linux-64 - we had a bit of a hiccup 2 days ago with the installation of Julia dependencies failing for select Python versions, see eg our full development mode GA tests but all is fine now, I guess the deps needed a couple days to get used to the new version anyway :grin: