Closed regro-cf-autotick-bot closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@krassowski There is an inconsistency between the python package and the conda package for jupyterlab-lsp
. This one force jupyter-lsp
version to the latest version when the python package states jupyter-lsp>=1.1.0
. Should we align that behaviour? If so which constrain should be updated; the one in this recipe or the one in jupyterlab-lsp/setup.cfg
?
No strong opinion. Maybe keeping an exact pin would be easier than changing it each time. What are you experiences from jupyterlab-git and other packages?
The pin between the two is somewhat tough: it kinda depends on what the behavior is when folks upgrade. Upstream we don't test the about-to-be-release versions against historical versions, so the upstream really only guarantees that the latest are working, which was kind of my thinking here. This would have to be a nightly CI, i guess, as we can't slow down CI any more.
Given we were considering packaging everything together, i think demanding at least the most-recently-packaged-at-the-same-time version probably makes the most sense. Going any further, e.g. =={{server_version}}`` is probably _not_ what we want, as then it becomes impossible to do patch releases of server of
jupyter-lspwithout doing another
jupyterlab-lsp`.
So I think we just ship with what we have here, and I'll make an issue upstream.
What are you experiences from jupyterlab-git and other packages?
Actually I never published front and back extensions separately. When updating to JLab3 I pick-up the highest version of both if they were not aligned to avoid package resolution errors. This of course implies republishing the python code even if the change is only in the frontend. If we would to choose that principle for jupyterlab-lsp, this means the version needs to be aligned with the frontend version. This will definitely ease the maintenance on the conda side.
Yeah, well... the goal is to be able to support other clients that might not be The JupyterLab, and be testable outside of jupyterlab. If we do pursue the kernel approach, it won't even be sane to depend on a particular client. If somebody wants to write one that works for nteract, colab or whatever, hooray! Maybe they'll PR something. But they definitely won't if it only works with JupyterLab. As a downstream, I'll take slightly more complicated conda over hard and incompatible forks any day.
Make sense @bollwyvl. Thanks for the detailed answer
It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:
license_file
is packagedNote that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</code
please add bot automerge
in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!If this PR was opened in error or needs to be updated please add the
bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (
conda install -c conda-forge rever
) and pip (pip install re-ver
) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/546399634, please use this URL for debuggingHere is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.
Packages found by inspection but not in the meta.yaml:
Packages found in the meta.yaml but not found by inspection: