Revert "add temporary run_constrained for autopep8"

izahn commented 2 years ago

This reverts commit 7f953f72cc0db32d9f7eecf8a6983abef24cfff3.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

izahn commented 2 years ago

@conda-forge-admin please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/jupyter-lsp-feedstock/actions/runs/1665900465.

izahn commented 2 years ago

@conda-forge/jupyter-lsp I think this is safe now. This PR is ready for review

bollwyvl commented 2 years ago

Thanks for the contribution, but the tests over here are rather lightweight so "green is good" isn't probably good enough over here. Perhaps you could PR this over on the upstream before relaxing the pin here.... we wouldn't even have wait to get it merged, necessarily, as the upstream never actually ships that pin, even behind an [extra] flag...

bollwyvl commented 2 years ago

Actually: looking at the pin in question: this is ignoring out a specific build (1.6.0=*_0) and that build is still and always will be broken... but either way, we can evaluate getting rid of it once upstream is changed. Given this has happened a number of times, it might be worth keeping the pin in, just so we have a record of, "yeah, auotpep8 can break stuff." I'd be a lot happier if that feedstock was running tests, but not looking for more work.

izahn commented 2 years ago

Ah right, I see. I was trying to solve this problem:

$ mamba install -q jupyter-lsp-python=1.5.1 spyder=5.2.1
Encountered problems while solving:
  - package python-lsp-server-1.3.3-pyhd8ed1ab_0 requires autopep8 >=1.6.0,<1.7.0, but none of the providers can be installed

and when I saw the package pin I hoped the fix would be as easy as removing it, but I see now this won't work until autopep8 1.6.1. Sorry for the noise.

krassowski commented 2 years ago

I wonder why it does not install 1.6.0_1 though? Did you try solving with conda? While I do find mamba better in most cases, maybe it does not support build pins properly?

izahn commented 2 years ago

Hmm the plot thickens...

$ mamba create -q -n test autopep8=1.6 'jupyter-lsp-python>=1.5.1' 'spyder=5.2.1=py39hf3d152e_1'                                                                  (base) 
Encountered problems while solving:
  - package jupyter-lsp-python-1.5.1-pyhd8ed1ab_0 has constraint autopep8 !=1.6.0 *_0 conflicting with autopep8-1.6.0-pyhd8ed1ab_0

Even when being 100% explicit mamba isn't buying it:

$ mamba create -q -n test 'autopep8=1.6.0=pyhd8ed1ab_1' 'jupyter-lsp-python>=1.5.1' 'spyder=5.2.1=py39hf3d152e_1'                                            (base) 
Encountered problems while solving:
  - package jupyter-lsp-python-1.5.1-pyhd8ed1ab_0 has constraint autopep8 !=1.6.0 *_0 conflicting with autopep8-1.6.0-pyhd8ed1ab_1

which seems to suggest that indeed mamba isn't reading that pin right. But then conda doesn't do any better:

$ conda create -q -n test 'autopep8=1.6.0=pyhd8ed1ab_1' 'jupyter-lsp-python>=1.5.1' 'spyder=5.2.1=py39hf3d152e_1'                                                 (base) 
Collecting package metadata (current_repodata.json): ...working... done
Solving environment: ...working... failed with repodata from current_repodata.json, will retry with next repodata source.
Collecting package metadata (repodata.json): ...working... done
Solving environment: ...working... 
Found conflicts! Looking for incompatible packages.
This can take several minutes.  Press CTRL-C to abort.
failed                                                                                                                                                                          

UnsatisfiableError: The following specifications were found to be incompatible with each other:

Output in format: Requested package -> Available versions

Package toml conflicts for:
spyder==5.2.1=py39hf3d152e_1 -> pylint[version='>=2.5.0'] -> toml[version='>=0.7.1|>=0.9.2']
autopep8==1.6.0=pyhd8ed1ab_1 -> toml

Package entrypoints conflicts for:
jupyter-lsp-python[version='>=1.5.1'] -> jupyter-lsp==1.5.1=pyhd8ed1ab_0 -> entrypoints
spyder==5.2.1=py39hf3d152e_1 -> keyring[version='>=17.0.0'] -> entrypoints[version='>=0.2.2']

Package autopep8 conflicts for:
spyder==5.2.1=py39hf3d152e_1 -> python-lsp-server[version='>=1.3.2,<1.4.0'] -> autopep8[version='>=1.6.0,<1.7.0']
jupyter-lsp-python[version='>=1.5.1'] -> python-lsp-server[version='>=1'] -> autopep8[version='<1.6.0|>=1.6.0,<1.7.0']

So maybe there is a problem with the way the pin is specified here?

conda-forge / jupyter-lsp-feedstock

Revert "add temporary run_constrained for autopep8" #41