Remove cruft files in the output

akhmerov commented 9 months ago

Should close #11

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

12rambau commented 9 months ago

Is it something that should be done for every pyproject.toml base python package or is it only related to hatch ?

akhmerov commented 9 months ago

I'm not sure. One thing that I did change was {{ PYTHON }} to python, otherwise I was getting jinja template errors of PYTHON not being defined.

akhmerov commented 9 months ago

https://github.com/conda-forge/typing_extensions-feedstock/blob/main/recipe/meta.yaml that I used as a source doesn't have any extra pip flags.

akhmerov commented 9 months ago

@conda-forge-admin, please rerender

github-actions[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/jupyter-sphinx-feedstock/actions/runs/7680280199.

akhmerov commented 9 months ago

Clobber warnings are gone from the logs, so I'll merge.

moorepants commented 9 months ago

Is it something that should be done for every pyproject.toml base python package or is it only related to hatch ?

pip's normal behavior is to detect if a dependency is present in site-packages and, if so, it skips downloading it from pypi. This means that you can always manually setup your dependencies and then pip install to effectively get a no pip managed dependency install. I am not familiar with hatch but if it does not follow this behavior, i.e. downloads packages regardless of what is present in site-packages, then you will have to disable this in hatch. conda needs to completely manage the dependencies in the build and if there are other processes that also do so, there will be problems. We've been deleting the pyproject.toml file in many cases to avoid this, see https://github.com/conda-forge/conda-forge.github.io/issues/1174 for some info. I think now people are using things like poetry and hatch in the conda build, but you have to carefully make sure it doesn't try to do any dependency management.

@akhmerov thanks for fixing this. All looks good now!

moorepants commented 9 months ago

FYI: https://github.com/conda-forge/conda-forge.github.io/pull/2044/files (has something to do with "outputs").

conda-forge / jupyter-sphinx-feedstock

Remove cruft files in the output #12