build 2 outputs - Githubissues

conda-forge / jupyter-sphinx-feedstock

A conda-smithy repository for jupyter-sphinx.

BSD 3-Clause "New" or "Revised" License

0 stars 5 forks source link

build 2 outputs #8

Closed 12rambau closed 9 months ago

12rambau commented 10 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'jupyter_sphinx' output doesn't have any tests.

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

Failed to even lint the recipe, probably because of a conda-smithy bug :cry:. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

12rambau commented 9 months ago

@ocefpaf, I tried to apply the example you shared with me but I fear I didn't understand how to have 2 outputs in one single recipe.

Could you give me a small insight from here?

akhmerov commented 9 months ago

I've stumbled upon a discussion about how to properly supply two packages from the same feedstock. It pointed to this unmerged part of the docs. I'll give a shot if changing the name variable fixes the issue.

akhmerov commented 9 months ago

@conda-forge-admin, please rerender

akhmerov commented 9 months ago

I ended up copying the idea from https://github.com/conda-forge/typing_extensions-feedstock/blob/main/recipe/meta.yaml, which is listed as a good example of how to make an alias in https://github.com/conda-forge/conda-forge.github.io/issues/746

12rambau commented 9 months ago

thanks very much @akhmerov for managing to make it work

ocefpaf commented 9 months ago

Could you give me a small insight from here?

Sorry for being late here but this looks good. Thank you both for taking this one to the finish line!