search

conda-forge / jupyter_core-feedstock

A conda-smithy repository for jupyter_core.
BSD 3-Clause "New" or "Revised" License
2 stars 21 forks source link

Arch Migrator #20

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 5 years ago

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it without reaching out the the ARM migrators first at @conda-forge/arm-arch.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 5 years ago

I didn't participate much in the initial push for the arch migration... looks good, but is there anything in particular to look out for?

jakirkham commented 4 years ago

Probably not here. Most of the issues have been subtle differences in numerical precision, and adding missing dependencies (like make). These issues would cause builds to fail outright. So I think you are safe to merge 🙂

jakirkham commented 4 years ago

Thanks @bollwyvl! You may see more of these PRs show up in the Jupyter stack. I think the same guidance applies 🙂

bollwyvl commented 4 years ago

Thank you, sorry for the delay!

On Tue, Nov 26, 2019, 16:13 jakirkham notifications@github.com wrote:

Thanks @bollwyvl https://github.com/bollwyvl! You may see more of these PRs show up in the Jupyter stack. I think the same guidance applies 🙂

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/conda-forge/jupyter_core-feedstock/pull/20?email_source=notifications&email_token=AAALCRDINMGDUXGVN4QCYZ3QVWGODA5CNFSM4JOH7KMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFHOPQY#issuecomment-558819267, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCRA5UO55T3T3JYBC3T3QVWGODANCNFSM4JOH7KMA .

jakirkham commented 4 years ago

Not at all. In fact sorry for the slow response. Also thanks for checking 🙂