conda-forge / jupyter_core-feedstock

A conda-smithy repository for jupyter_core.
BSD 3-Clause "New" or "Revised" License
2 stars 21 forks source link

Rebuild for pypy #27

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 4 years ago

This PR has been triggered in an effort to update pypy.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children: ipykernel ipython And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/15004, please use this URL for debugging

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 4 years ago

@conda-forge/bot, the traitlets which is a dep has not been built for pypy yet, so I'm not sure why this PR was sent

beckermr commented 4 years ago

Edges out of date.

isuruf commented 4 years ago

@bollwyvl, @ocefpaf, is it okay to remove the ipykernel as a test dependency here because of the cycle? jupyter_core->ipykernel (for testing)->jupyter_client->jupyter_core

ocefpaf commented 4 years ago

It is @isuruf. In the past we removed and added it back. We don't have a more elegant way to handle cycles like those.

isuruf commented 4 years ago

@ocefpaf, done. Can you review?

bollwyvl commented 4 years ago

@conda-forge-admin please rerender

bollwyvl commented 4 years ago

Merged these in the wrong order: will work on fix

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

bollwyvl commented 4 years ago

We don't have a more elegant way to handle cycles like those.

Perhaps for known cases like this, we introduce a jinja convention, e.g.

{% set cf_adding_new_build = True %}

test:
  requires:
    {% if not cf_adding_new_build %}
    - ipykernel
    {% endif %}
  commands:
    {% if not cf_adding_new_build %}
    - python -m pytest --pyargs jupyter_core -k "{{ skip }}"
    {% endif %}

then the bot would just have to know how to update the one boolean.

bollwyvl commented 4 years ago

recipe-lint reports no issues locally: provided it passes, LGTM, but will be away from my box for the balance of the day.

beckermr commented 4 years ago

@conda-forge-admin re-lint

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 4 years ago

Nice, good spell to know!

On Fri, Mar 13, 2020, 08:42 Automatic conda-forge linter < notifications@github.com> wrote:

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR ( recipe) and found it was in an excellent condition.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/conda-forge/jupyter_core-feedstock/pull/27#issuecomment-598701515, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALCREQWMCCFQUVFJQNGYDRHIS3FANCNFSM4LF4MVRQ .

bollwyvl commented 4 years ago

Looks good!