conda-forge / jupyter_core-feedstock

A conda-smithy repository for jupyter_core.
BSD 3-Clause "New" or "Revised" License
2 stars 21 forks source link

manually start PyPy migration #51

Closed mattip closed 1 year ago

mattip commented 2 years ago

Checklist

The dependency resolver bot did not start the pypy3.8/3.9 migration because pywin32 is a parent in the graph. But I think pywin32 is an optional dependency for PyPy, not a hard one. The PR works around the problem by manually adding the migration file.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mattip commented 2 years ago

Any ideas why these three tests are failing to find the srcdir in shutil.copytree? Is that something known about pypy, windows, and jupyter_core?

FAILED tests/test_command.py::test_argv0 - subprocess.CalledProcessError: Com...
FAILED tests/test_migrate.py::test_migrate_dir - shutil.Error: [('C:\\Users\\...
FAILED tests/test_migrate.py::test_migrate_one - shutil.Error: [('C:\\Users\\...
blink1073 commented 2 years ago

I'm not sure, we only test pypy on Ubuntu in CI.

bollwyvl commented 2 years ago

yerp: if we could figure out the right noarch invocation over on #49, we could save a lot of coal...

mattip commented 1 year ago

Outdated, closing