conda-forge / jupyter_core-feedstock

A conda-smithy repository for jupyter_core.
BSD 3-Clause "New" or "Revised" License
2 stars 21 forks source link

Make noarch: python (ignore pypy) #95

Closed bollwyvl closed 1 month ago

bollwyvl commented 1 month ago

Checklist

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

bollwyvl commented 1 month ago

@conda-forge-admin please rerender

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/jupyter_core-feedstock/actions/runs/10985307266.

bollwyvl commented 1 month ago

@conda-forge/jupyter_core we could:

minrk commented 1 month ago

Can we do a noarch_platforms variant list like we do for ipykernel? But with variants:

and put runconstrained on `- python {{ implementation }}`?

Alternatively, we could have two variants, one with pywin32-on-windows dependency and one without, with the one without penalized by a feature or build offset. Effectively 'preferring' pywin32 on windows, but not requiring it.

minrk commented 1 month ago

Given the pypy transition, if this proves difficult, I think it's probably also okay to drop pypy here for new builds for now, and then try to get it back in a later build, if there's a need to keep things moving. LMK if you want a hand to try to get the variants built.