conda-forge / jupyterlab_code_formatter-feedstock

A conda-smithy repository for jupyterlab_code_formatter.
BSD 3-Clause "New" or "Revised" License
0 stars 7 forks source link

Update meta.yaml from upstream build dependencies #48

Closed achimgaedke closed 1 year ago

achimgaedke commented 1 year ago

fixing up build pipeline reflecting build dependency changes for upstream version 2

there are also some runtime dependency changes, but first focussing on repairing build...

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

achimgaedke commented 1 year ago

Hmmm, looks like I'm not understanding what's going on here.... Will need to read up a bit more / use docker for debugging locally.

felixgwilliams commented 1 year ago

Thanks for having a look at this. It looks like if the requirements part is changed to the following, it seems to be successful:

requirements:
  host:
    - hatchling >=1.4.0
    - hatch-nodejs-version
    - hatch-jupyter-builder>=0.5
    - python >=3.7
    - pip
  run:
    - jupyter_server >=1.21,<3
    - python >=3.7
achimgaedke commented 1 year ago

Thanks, @felixgwilliams - I also started understanding that I confuse hostand build... too many "isolated virtual" environments.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

achimgaedke commented 1 year ago

Ok, https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#host is clear about this: architecture-independent packages use host.

I've used @felixgwilliams suggestions - and will ready this PR for review.