Closed achimgaedke closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
requirements: build: python >= 3.7
should not contain a space between relational operator and the version, i.e. python >=3.7
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Hmmm, looks like I'm not understanding what's going on here.... Will need to read up a bit more / use docker for debugging locally.
Thanks for having a look at this. It looks like if the requirements part is changed to the following, it seems to be successful:
requirements:
host:
- hatchling >=1.4.0
- hatch-nodejs-version
- hatch-jupyter-builder>=0.5
- python >=3.7
- pip
run:
- jupyter_server >=1.21,<3
- python >=3.7
Thanks, @felixgwilliams - I also started understanding that I confuse host
and build
... too many "isolated virtual" environments.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
requirements: host: hatch-jupyter-builder>=0.5
must contain a space between the name and the pin, i.e. hatch-jupyter-builder >=0.5
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Ok, https://docs.conda.io/projects/conda-build/en/stable/resources/define-metadata.html#host is clear about this: architecture-independent packages use host
.
I've used @felixgwilliams suggestions - and will ready this PR for review.
fixing up build pipeline reflecting build dependency changes for upstream version 2
there are also some runtime dependency changes, but first focussing on repairing build...
Checklist
0
(if the version changed)