conda-forge / kedro-viz-feedstock

A conda-smithy repository for kedro-viz.
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Fix Broken Recipe Issues #12

Closed rxm7706 closed 1 year ago

rxm7706 commented 1 year ago

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

rxm7706 commented 1 year ago

This is a safer pin - given that httpcore & httpx are key packages used across the kedro ecosystem (Airflow, ML-FLOW) - still not clear why this suddenly caused issues.

rxm7706 commented 1 year ago

@millsks - I did deep dive into this -- Right now the gap between the PiP requirements and Conda Recipe is S3FS - PiP is using fsspec[s3]>=2021.4, <2024.1 - i.e. installing "s3": ["s3fs"],

Leading to a gap of these packages - https://github.com/fsspec/s3fs/blob/main/requirements.txt aiobotocore~=2.6.0 aiohttp!=4.0.0a0, !=4.0.0a1

image

So I think its the downgrade of urllib3 from 2.0.6 to 1.26.17 is the root cause.

httpx is not installed at all when I create a fresh env and install kedro-viz via pip or conda.

Comparing these two environments conda create -n kedro-viz-conda "python=3.10" (then conda install kedro-viz) vs conda create -n kedro-viz-pip "python=3.10" (then pip install kedro-viz)

confirms that the kedro-viz-conda is missing s3fs and dependencies

The only two packages that were exclusive to kedro-viz-pip were platformdirs | 3.11.0 & build |1.0.3

I dont think those are the cause of the discrepancies / issues you ran into