Open NeroOkwa opened 1 year ago
For the record, @rxm7706 and I have been struggling a bit to get kedro-viz properly built on conda-forge, you can see some of our earlier efforts in https://github.com/conda-forge/staged-recipes/pull/22142 and some more background in https://github.com/kedro-org/kedro-viz/issues/1267
Unfortunately nothing caught this and this saga continues -
I think whats needed might be available in the release targz.. and just need to be copied over form /public to /package https://github.com/kedro-org/kedro-viz/blob/50ebfe616d8295d0a5e9aeff5da5dc56ebe74922/Makefile#L3C1-L13C36
Trying to solve this at the conda packing level may not even be possible at this point, and we need a new release / distribution and focus on the core packaging issues @astrojuanlu raised.
Will try and take a look at options.
I was able to reproduce the issue. I believe the reason the recipe build did not fail was because the kedro_viz module is able to import successfully from inside the python interpreter. Once you try to execute kedro viz
from the command line, then that is where it is throwing the issue.
(kedro310-conda) millsks@ATREIDES:~/UserLocal/projects/spaceflights$ python
Python 3.10.12 | packaged by conda-forge | (main, Jun 23 2023, 22:40:32) [GCC 12.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import kedro_viz
>>> kedro_viz.__version__
'6.3.4'
From what we can tell the build tarball on the repo where the recipe is pointed at doesn't have the kedro_viz/html
files. This is most likely because the release tarball is a snapshot of pre-build and npm run build
has not been executed yet.
More to come.
In the conda recipe - we need to replace uvicorn with uvicorn-standard ; to match uvicorn[standard]~=0.22.0 at https://github.com/kedro-org/kedro-viz/blob/main/package/requirements.txt#L7C1-L7C26
This was fixed in #7 🎉
Solution to issue cannot be found in the documentation.
Issue
I tried installing Kedro-Viz as per the instruction on conda-forge and got an error message of missing index.html.
These are the steps I followed:
This was my error message:
Environment info