conda-forge / kedro-viz-feedstock

A conda-smithy repository for kedro-viz.
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Update to Version 6.4.0 #8

Closed rxm7706 closed 1 year ago

rxm7706 commented 1 year ago
  1. There is something different / new about sass, where referential path to the style sheet is not being picked up, perhaps because of where sass is running on conda-forge vs the development process. Compiling fails saying cannot find '../../../../node_modules/highlight.js/styles/a11y-light'. So I am still using a modified copy of metadata-code-themes.scss

/src/components/metadata/styles/

That changes

  @include meta.load-css(
    '../../../../node_modules/highlight.js/styles/a11y-light'
  );
}

to

  @include meta.load-css(
    './a11y-light'
  );
}

That requires placing a copy of both a11y-light.css and a11y-dark.css in the same folder as metadata-code-themes.scss /src/components/metadata/styles/

  1. npm install --save react@17.0.2 react-dom@17.0.2 sass@1.54.4 react-scripts@4.0.3 cypress@12.14.0 is needed for https://github.com/kedro-org/kedro-viz/blob/main/package.json to execute.

  2. NODE_OPTIONS=--openssl-legacy-provider was added as an option before running NPM build @astrojuanlu

  3. HTML and Static files from build need to be copied to /package/kedro_viz/html

  4. scikit-learn has dropped max_features="auto" https://github.com/kedro-org/kedro-viz/blob/main/demo-project/conf/base/parameters/modelling.yml#L24 https://github.com/scikit-learn/scikit-learn/pull/20255 I had to change that to max_features: 'sqrt'

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

rxm7706 commented 1 year ago

@conda-forge-admin, please rerender

rxm7706 commented 1 year ago

@millsks @NeroOkwa

I was able to test kedro-viz==6.4.0 locally - and run the kedro-demo locally ; was able to see preview datasets and experiment tracking.

@astrojuanlu kedro-demo project in kedro-viz seems a bit outdated (packages etc) also https://github.com/kedro-org/kedro-viz/blob/main/demo-project/conf/base/parameters/modelling.yml#L24 scikit-learn has dropped max_features="auto" https://github.com/scikit-learn/scikit-learn/pull/20255 I had to change that to max_features: 'sqrt'

Test Screen Shots Below image

image

astrojuanlu commented 1 year ago

@astrojuanlu kedro-demo project in kedro-viz seems a bit outdated (packages etc) also https://github.com/kedro-org/kedro-viz/blob/main/demo-project/conf/base/parameters/modelling.yml#L24 scikit-learn has dropped max_features="auto" https://github.com/scikit-learn/scikit-learn/pull/20255 I had to change that to max_features: 'sqrt'

Could you please open an issue upstream, for visibility? cc @tynandebold

Also, I tested the previous version and looks good, so I'm confident that this one will work as well ⭐ Thanks folks!