search

conda-forge / kwant-feedstock

A conda-smithy repository for kwant.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

Rebuild for python38 #78

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 4 years ago

This PR has been triggered in an effort to update python38.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/15843, please use this URL for debugging

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

beckermr commented 4 years ago

So closing this PR marks it as done according to the bot. The comment from the linter was incidental, which is rather confusing for sure. We'll have to mark the PR as not done in the bot's metadata by hand if you want it to be actually rerun.

cc @conda-forge/bot

basnijholt commented 4 years ago

@beckermr, the closing of this PR was unintentional.

I force pushed the branch to the state of upstream/master (to manually solve the merge conflicts) and then GitHub closed it.

I believe I have to make a change to https://github.com/regro/cf-graph-countyfair/blob/master/node_attrs/kwant.json but I am unsure what should change exactly.

basnijholt commented 4 years ago

@beckermr, this is what I tried https://github.com/regro/cf-graph-countyfair/pull/11.

beckermr commented 4 years ago

Was the bot rerun label added when it was closed? This is the only condition under which the PR would be closed.

basnijholt commented 4 years ago

The rerun label was added 5 minutes before it was closed.

beckermr commented 4 years ago

OK. So the time stream above indicates you closed the PR. In any case, once one adds the bot rerun label, it takes a while for the bots to get back to the PR to fix things up. This is why it might have seemed delayed. Your PR on the graph looks good. I am going to wait about 10 minutes for the graph to finish its current run and then merge it.