conda-forge / kwant-feedstock

A conda-smithy repository for kwant.
BSD 3-Clause "New" or "Revised" License
0 stars 10 forks source link

add a build variant that links Kwant against mumps-mpi #90

Closed basnijholt closed 3 years ago

basnijholt commented 3 years ago

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

basnijholt commented 3 years ago

@conda-forge-admin, please rerender

jbweston commented 3 years ago

@conda-forge-admin, please rerender

jbweston commented 3 years ago

All the tests now pass, but when I manually install kwant and fenics together in the same environment fenics gives all sorts of warnings on import about integer size mismatches.

akhmerov commented 3 years ago

Do you think these warnings indicate that things are broken?

jbweston commented 3 years ago

Do you think these warnings indicate that things are broken?

Yes, but I don't know what it is exactly. I suspect that it is due to a difference in compile-time and run-time versions of MPI.

basnijholt commented 3 years ago

Great work Joe!

I say, let's go ahead and merge 👍

akhmerov commented 3 years ago

A quick question. If a user writes mamba install kwant in a fresh env, which variant is installed? Can we select a default?

basnijholt commented 3 years ago

The default will be the nompi build, this is because we set the build number higher, so the default stays the same.

If someone prefers the mpi version, one should specify: conda install "kwant=*=*mpi".

akhmerov commented 3 years ago

Ah, I see that now. Neat! Please add a comment around that line to explain the purpose of the build number bump.

Given that I'm :+1: on merging, but I'd like @jbweston's confirmation.

jbweston commented 3 years ago

We can't merge because things are still broken!

For clarity here's what happens when I import fenics in an environment where the mpi variant of kwant is installed: image

@basnijholt also, as our variants are named nompi and mpi I think this means if we want the mpi variant we have to specify kwant=*=*_mpi with a weird leading underscore. This is because kwant=*=*mpi will also match nompi.

basnijholt commented 3 years ago

@jbweston, this seems unrelated to the changes made here.

Try installing the current version of kwant in Python 3.9 to get the same warnings.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

basnijholt commented 3 years ago

@conda-forge-admin, please rerender

jbweston commented 3 years ago

@jbweston, this seems unrelated to the changes made here.

Try installing the current version of kwant in Python 3.9 to get the same warnings.

Indeed, conda create -n fenics-alone -c conda-forge fenics; conda activate fenics-alone; python -c 'import fenics' gives these warnings, so it's not us.

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!