Closed basnijholt closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
@conda-forge-admin, please rerender
All the tests now pass, but when I manually install kwant and fenics together in the same environment fenics gives all sorts of warnings on import about integer size mismatches.
Do you think these warnings indicate that things are broken?
Do you think these warnings indicate that things are broken?
Yes, but I don't know what it is exactly. I suspect that it is due to a difference in compile-time and run-time versions of MPI.
Great work Joe!
I say, let's go ahead and merge 👍
A quick question. If a user writes mamba install kwant
in a fresh env, which variant is installed? Can we select a default?
The default will be the nompi
build, this is because we set the build number higher, so the default stays the same.
If someone prefers the mpi version, one should specify: conda install "kwant=*=*mpi"
.
Ah, I see that now. Neat! Please add a comment around that line to explain the purpose of the build number bump.
Given that I'm :+1: on merging, but I'd like @jbweston's confirmation.
We can't merge because things are still broken!
For clarity here's what happens when I import fenics
in an environment where the mpi variant of kwant is installed:
@basnijholt also, as our variants are named nompi
and mpi
I think this means if we want the mpi variant we have to specify kwant=*=*_mpi
with a weird leading underscore. This is because kwant=*=*mpi
will also match nompi
.
@jbweston, this seems unrelated to the changes made here.
Try installing the current version of kwant in Python 3.9 to get the same warnings.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
meta.yaml
, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint .
from the recipe directory. Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
@jbweston, this seems unrelated to the changes made here.
Try installing the current version of kwant in Python 3.9 to get the same warnings.
Indeed, conda create -n fenics-alone -c conda-forge fenics; conda activate fenics-alone; python -c 'import fenics'
gives these warnings, so it's not us.
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)