Split packages - Githubissues

conda-forge / lapack-feedstock

A conda-smithy repository for lapack.

BSD 3-Clause "New" or "Revised" License

6 stars 12 forks source link

Split packages #15

Closed isuruf closed 5 years ago

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The recipe must have some tests.

isuruf commented 5 years ago

@conda-forge-admin, please rerender.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The recipe must have some tests.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The recipe must have some tests.
Jinja2 variable definitions are suggested to take a {%<one space>set<one space><variable name><one space>=<one space><expression><one space>%} form. See lines [5, 7]

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The recipe must have some tests.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 5 years ago

@conda-forge/lapack, do you mind if I push the artifacts built here to the conda-forge/label/blas-dev channel?

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'libblas' output doesn't have any tests.
It looks like the 'libcblas' output doesn't have any tests.
It looks like the 'liblapack' output doesn't have any tests.
It looks like the 'liblapacke' output doesn't have any tests.

isuruf commented 5 years ago

Merging this to a separate branch and label

hmaarrfk commented 5 years ago

awesome work!!!!! This upgrade will probably go a long way toward getting it to work with the new compilers!!!

mariusvniekerk commented 5 years ago

@isuruf you may want to edit this PR to change the base to split, so that you can merge it?

isuruf commented 5 years ago

@conda-forge-admin, rerender

isuruf commented 5 years ago

@conda-forge-admin, rerender