search

conda-forge / lapack-feedstock

A conda-smithy repository for lapack.
BSD 3-Clause "New" or "Revised" License
6 stars 12 forks source link

Adding libtmglib. #49

Closed hhslepicka closed 3 years ago

hhslepicka commented 3 years ago

Closes #48

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

hhslepicka commented 3 years ago

@conda-forge-admin, please rerender

hhslepicka commented 3 years ago

@isuruf this seems good for a review... Thank you for the guidelines on how to do it.

I added tests for the outputs and later I realized that they are likely being covered by blas. I can revert https://github.com/conda-forge/lapack-feedstock/pull/49/commits/715f6b337c8580e68e5d58e6076a61546de2e3b4 if that's a problem.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

hhslepicka commented 3 years ago

Duplicated tests were reverted via https://github.com/conda-forge/lapack-feedstock/pull/49/commits/3561e257a8c8384da1e1ed46efdfd751a3b8ad03

hhslepicka commented 3 years ago

@isuruf @jakirkham I am not sure why osx_arm64 is no longer recognizing the gfortran compiler. The latest feedstock build worked but for PRs it is failing. It seems unrelated to this change. I will try to find the difference between them but I would appreciate if you could take a look.

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

hhslepicka commented 3 years ago

@conda-forge-admin, please restart CI

h-vetinari commented 3 years ago

Bit further up in the log:

-- The Fortran compiler identification is GNU 11.0.0
arm64-apple-darwin20.0.0-gfortran: fatal error: cannot execute ‘cc1’: execvp: No such file or directory
compilation terminated.

Not sure where cc1 is supposed to come from either though.

hhslepicka commented 3 years ago

@h-vetinari the cc1 missing is due to a known issue with gfortran under OS X. The issue and workaround can be found here: https://github.com/conda-forge/gfortran_osx-64-feedstock/issues/11#issuecomment-725890478

I can try to add that to get rid of the warning but my concern is more with the seg fault happening during compilation.