Update to 3.11 - Githubissues

conda-forge / lapack-feedstock

A conda-smithy repository for lapack.

BSD 3-Clause "New" or "Revised" License

6 stars 12 forks source link

Update to 3.11 #63

Closed jschueller closed 7 months ago

jschueller commented 1 year ago

Closes #62

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'libblas' output doesn't have any tests.
It looks like the 'libtmglib' output doesn't have any tests.
It looks like the 'libcblas' output doesn't have any tests.
It looks like the 'liblapack' output doesn't have any tests.
It looks like the 'liblapacke' output doesn't have any tests.
It looks like the 'blas-devel' output doesn't have any tests.
It looks like the 'lapack' output doesn't have any tests.

jschueller commented 1 year ago

@conda-forge-admin please rerender

jschueller commented 1 year ago

ready to go @conda-forge/lapack

h-vetinari commented 1 year ago

We waited a really long time to get #51 merged, because we basically want all BLAS/LAPACK implementations to support the same LAPACK feature level, and MKL is generally far behind.

Also, we haven't enabled 3.10 in the blas-metapackage yet, which is IMO the next reasonable step...

jschueller commented 1 year ago

ok, yes, I figured 3.9 was really old :) but anyway this is independent of the global pinning and we can still update the feedstock to ease the next version update

isuruf commented 1 year ago

Merging this as is will make the netlib variant higher priority. Here's what we can do,

Merge this PR with target to conda-forge/label/lapack
Build blas-metapackage without MKL and drop windows for 3.11
Move these pacakges to main label

To be clear this only gives the ability of downstream feedstocks to target new APIs in 3.10 and 3.11, but not any performance benefits as we enable latest versions of openblas, MKL, etc with 3.9.

jschueller commented 1 year ago

ok, in this case it can wait, I let you decide

h-vetinari commented 7 months ago

The Intel team helping us with repackaging MKL has asked to be able to test blas metapackage against LAPACK 3.11, as there are failures with 3.10.1.

The main branch here already points to a separate label: https://github.com/conda-forge/lapack-feedstock/blob/f675059b113d06f34332c359cc18f505554724d9/recipe/conda_build_config.yaml#L1-L2

so we can safely merge this PR. Then it becomes easy to test the various implementations against 3.11 on the blas feedstock, without yet making this generally available.

PS. Thanks a lot for the PR!